Allow Not generating Canary Service && Fixed a bug caused by NOT considering case-insensitivity. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @myname4423! It looks like this is your first PR to openkruise/rollouts 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 43.41% 43.42%
=======================================
Files 52 52
Lines 5675 5677 +2
=======================================
+ Hits 2464 2465 +1
- Misses 2786 2787 +1
Partials 425 425
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yunbo <[email protected]>
|
New changes are detected. LGTM label has been removed. |
myname4423
changed the title
myname4423
changed the title
amend1: update crd yaml amend2: add DisableGenerateCanaryService for v1alpha1 Signed-off-by: yunbo <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
myname4423
pushed a commit
to myname4423/rollouts
that referenced
this pull request
Mar 13, 2024
Signed-off-by: yunbo <[email protected]>
myname4423
pushed a commit
to myname4423/rollouts
that referenced
this pull request
Mar 13, 2024
Signed-off-by: yunbo <[email protected]>
lujiajing1126
pushed a commit
to lujiajing1126/rollouts
that referenced
this pull request
Mar 15, 2024
…idering case-insensitivity. (openkruise#200) * Fixed a bug caused by NOT considering case-insensitivity. Signed-off-by: yunbo <[email protected]> * add DisableGenerateCanaryService for CanaryStrategy amend1: update crd yaml amend2: add DisableGenerateCanaryService for v1alpha1 Signed-off-by: yunbo <[email protected]> --------- Signed-off-by: yunbo <[email protected]> Co-authored-by: yunbo <[email protected]> Signed-off-by: Megrez Lu <[email protected]>
kruise-bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
Signed-off-by: yunbo <[email protected]> Co-authored-by: yunbo <[email protected]>
kruise-bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
* support queryparams for gateway api Signed-off-by: Megrez Lu <[email protected]> * support mse Signed-off-by: Megrez Lu <[email protected]> * support path and queryParams Signed-off-by: Megrez Lu <[email protected]> * fix lint Signed-off-by: Megrez Lu <[email protected]> * fix testcase Signed-off-by: Megrez Lu <[email protected]> * fix manifests Signed-off-by: Megrez Lu <[email protected]> * do not provide default value for path Signed-off-by: Megrez Lu <[email protected]> * Allow Not generating Canary Service && Fixed a bug caused by NOT considering case-insensitivity. (#200) * Fixed a bug caused by NOT considering case-insensitivity. Signed-off-by: yunbo <[email protected]> * add DisableGenerateCanaryService for CanaryStrategy amend1: update crd yaml amend2: add DisableGenerateCanaryService for v1alpha1 Signed-off-by: yunbo <[email protected]> --------- Signed-off-by: yunbo <[email protected]> Co-authored-by: yunbo <[email protected]> Signed-off-by: Megrez Lu <[email protected]> * revert test images Signed-off-by: Megrez Lu <[email protected]> * polish comments Signed-off-by: Megrez Lu <[email protected]> * add gateway api tests Signed-off-by: Megrez Lu <[email protected]> * fix MSE cases Signed-off-by: Megrez Lu <[email protected]> * update golang lint ci Signed-off-by: Megrez Lu <[email protected]> * regenerate manifests Signed-off-by: Megrez Lu <[email protected]> * remove generic usage Signed-off-by: Megrez Lu <[email protected]> * update istio lua script Signed-off-by: Megrez Lu <[email protected]> * update v1alpha1 in e2e to v1beta1 Signed-off-by: Megrez Lu <[email protected]> * fix cases Signed-off-by: Megrez Lu <[email protected]> * refactor istio case to include queryParams and path Signed-off-by: Megrez Lu <[email protected]> * fix cloneset issue Signed-off-by: Megrez Lu <[email protected]> * fix typo Signed-off-by: Megrez Lu <[email protected]> * revert images Signed-off-by: Megrez Lu <[email protected]> --------- Signed-off-by: Megrez Lu <[email protected]> Signed-off-by: yunbo <[email protected]> Co-authored-by: myname4423 <[email protected]> Co-authored-by: yunbo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
NO
Ⅲ. Special notes for reviews
For 1:
when working with trafficRoutings.customNetworkRefs (such as VirtualService and DestinationRule for Istio), rollout will always generate canary Service based on the provided Service, which may be undesirable in the scenario of using DestinationRule subsets.
For 2:
In the code within
api/v1alpha1/conversion.go, when converting objects from v1alpha1 to v1beta1 (aka. the HUB version), a direct string comparison is made. This leads to an issue where v1alpha1 objects (Rollout and batchRelease) are only converted correctly to the v1beta1 object if the RolloutStyleAnnotation annotation is exactly "Partition" (with an uppercase initial letter). In other cases, where RolloutStyleAnnotation is "partition", "canary", or "Canary", the conversion defaults to the canary.